Yeah, sorry for the delay but there's a lot to unpack here:
First of all, the screenshot you uploaded (which is also the background image shipped in the game) contains textures from Minecraft, which is copyright infringement. For this to be legal, they've got to go.
Next, I'm seeing several mods in this game with no license assigned to them.
Not only that, some of the textures in these mods (for instance, emerald.png from the emerald mod) are clearly derivatives of other textures in the game with licenses that have attribution or other licensing requirements. Those aren't being followed properly right now.
Then, we have some really weird stuff. For instance:
License of source code
----------------------
Copyright (c) 2021 blocky_player.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
For more details:
http://creativecommons.org/licenses/by-sa/3.0/
This...appears to be 3/4s of the MIT license with a link to the CC BY-SA 3.0 license stapled on the end??? I have no idea how that would work out.
I saw this package was updated and took another look, not sure if you were done yet or not:
Screenshot is fine now
Unlicensed mods are still unlicensed
Derivative textures aren't handled yet
Broken license seems to be fixed now, unless I missed it
I also noticed some another issue in this pass:
There seem to be multiple copies of Minetest game for some reason, one in the mtg folder and one in nether. Not sure why, but it seems like an issue (at any rate, if this was on purpose you'd need to change the mod id due to Right to a Name issues)
Looks better, just one last thing to fix with the new emerald and ruby license files. It looks like these were copied from the amethyst mod, but you haven't updated them to refer to the new texture names. Here's an example of how you could handle this, I trust you can fix the rest easily:
Any comments are greatly appreciated.
We can't allow MC textures in the screenshot, also, a real screenshot may be appreciated and more illustrative.
Oh, and for games we highly recommend using the VCS of your liking, like GitHub or GitLab, or whatever you are most comfortable using.
Yeah, sorry for the delay but there's a lot to unpack here:
emerald.pngfrom the emerald mod) are clearly derivatives of other textures in the game with licenses that have attribution or other licensing requirements. Those aren't being followed properly right now.This...appears to be 3/4s of the MIT license with a link to the CC BY-SA 3.0 license stapled on the end??? I have no idea how that would work out.
Ok Im changing screenshot and license. Sorry about the MC textures.
will take a while because of school so sorry about that
No worries, take your time!
I saw this package was updated and took another look, not sure if you were done yet or not:
I also noticed some another issue in this pass:
mtgfolder and one innether. Not sure why, but it seems like an issue (at any rate, if this was on purpose you'd need to change the mod id due to Right to a Name issues)Ok. Updated mods and fixed some unlicensed mods also removed mtg modpack inside nether mod. Fixed red_steel.png images not done properly.
Looks better, just one last thing to fix with the new
emeraldandrubylicense files. It looks like these were copied from theamethystmod, but you haven't updated them to refer to the new texture names. Here's an example of how you could handle this, I trust you can fix the rest easily:This:
might become this:
After that I think this will be ok to publish!
Ok. Thanks for reviewing. I will be fixinng those too.
Alright, I think with this change we can approve now. Thank you for your patience.
Thanks for approving this game.