Package approval comments

Package: Hammermod

• 
  LandarVargan (Lone_Wolf) 2020-12-28 19:22 UTC

  Missing dependency on mcl_core

• 
  cultom Maintainer 2020-12-29 16:44 UTC

  yet ill will works with both and thanks for helping me

• 
  LandarVargan (Lone_Wolf) 2020-12-29 16:57 UTC

  Why did you undo the changes you made in your Github repo?

• 
  LandarVargan (Lone_Wolf) 2020-12-29 17:02 UTC

  You might like this code better btw:

  local ingredients = {
      stick     = "default:stick",
      ironBlock = "default:steelblock",
      ironIngot = "default:steel_ingot",
  }
  
  if minetest.get_modpath("mcl_core") then
      ingredients = {
          stick     = "mcl_core:stick",
          ironBlock = "mcl_core:ironblock",
          ironIngot = "mcl_core:iron_ingot",
      }
  end
  
  minetest.register_craft({
      output = "hammermod:steel_hammer",
      recipe = {
          {ingredients.ironIngot, ingredients.ironBlock, ingredients.ironIngot},
          {"", ingredients.stick, ""},
          {"", ingredients.stick, ""},
      },
  })
  

• 
  cultom Maintainer 2020-12-31 09:50 UTC

  i did what you proposed me and i reduced the durability of the hammer .

• 
  LandarVargan (Lone_Wolf) 2020-12-31 16:42 UTC

  Sorry, looks like my code has a flaw. I've made a PR that fixes it and also adds dependencies for you: https://github.com/cultom/hammermod/pull/2

• 
  cultom Maintainer 2021-01-01 10:41 UTC

  thanks you for helping me i'm new in programmation . and Happy new year!

• 
  rubenwardy 2021-01-01 23:57 UTC

  Two things:

  • The tunnel screenshot is badly cropped
  • The tunnel screenshot would probably make a better cover image than the tool, and the tool would make a better thumbnail than the tunnel
• 
  LandarVargan (Lone_Wolf) 2021-01-02 05:27 UTC

  Cropped the image for you but I'll let you arrange the screenshots how you want