I know that this is a VoxelForge adaptation, and I'm completely fine with that. But you completely missed the point of exposing functions.
mcl_cozy doesn't just provide the chatcommands, it also provides API for other mods to use.
Also, you're greatly overengineering things. Condition returns and line break avoidance don't improve readability. They might simplify the code from your standpoint, but I highly doubt any new developer would have a good time looking at it.
You decided to limit yourself to just the singular sit/lay animations through handle_action. That's fine with the mod being as it is (taking 2 commands as input), but anything more complex wouldn't do (say, a complex dance sequence of sneak+stand+sneak+mine).
You could've just done s/mcl/vlf on the original mod and it would've been much better.
First of all. Thank you for taking the time to review this.
I update things as they are requested, hence the reason that It's not exactly an api anymore. My target audience isn't really developers. But more regular players.
As far as I'm aware the api has not really been used by any mods (except one. And that was yours),so if noone is going to use the api it is just a waste of resources. There's no point in adding something that people won't make use of. If someone wants to make use of an api for this. I'd gladly re-add the api. I try to make things as resource friendly as possible. I just can't see any use of wasting more resources on an api that probably won't be used. (no matter how few resources it uses)
My target audience isn't really developers. But more regular players.
And I totally get it. That's normal. My target audience isn't developers either. But it doesn't change things.
The power of open-source is in collaboration. By making the code accessible only to you, you prevent people from contributing to it. A plumber won't be able to fix piping that they can't understand. (bad analogy but whatever)
BTW, what significance does "a greatly simplified and rewritten version" carry to regular players? That's clearly an attempt at selling this to developers, not players.
Offtopic: the screenshot you put in the long description doesn't render. You should link it to the ContentDB media file as everything else (e.g. imgur) seems to be broken by it.
The power of open-source is in collaboration. By making the code accessible only to you, you prevent people from contributing to it. A plumber won't be able to fix piping that they can't understand. (bad analogy but whatever)
I partly agree, but there's no point of adding something no one will use.
By making the code accessible only to you
I'm not sure I understand this.
"a greatly simplified and rewritten version"
Offtopic: the screenshot you put in the long description doesn't render. You should link it to the ContentDB media file as everything else (e.g. imgur) seems to be broken by it.
I accidently used the old readme (As In. I forgot to push the new one to git.)
I partly agree, but there's no point of adding something no one will use.
If I was able to use it, anybody can. The question of will is not something I can control, and neither can any developer.
Just because I'm not sure that there will be 9999 mods using my API doesn't mean I shouldn't expose it if I think it's useful.
I'm not sure I understand this.
You essentially decided to ignore the code style that Minetest (Game+mods) and MineClone family had adopted over the years and write whatever. I'm not arguing your code style is "wrong" or "bad", but instead that it's non-standard. This is better than if you ran your code through an obfuscator every time before releasing it to the public, yet it's worse than if you went on the comply route.
Again. Adopting an (at least somewhat) unified code style and guidelines helps everybody. Developer can get useful patches from Contributors; Contributors can have an understanding of the code they're given and learn from it too; Player can enjoy the results of that Developer-Contributor interaction (e.g. new features and whatnot).
If I, as a Contributor, have to learn your specific code style just to understand your code and try and contribute to it, I might just not.
And don't forget most contributors are players too. People play mods and games, look inside to see how they work, and then try and change things.
I know that this is a VoxelForge adaptation, and I'm completely fine with that. But you completely missed the point of exposing functions.
mcl_cozydoesn't just provide the chatcommands, it also provides API for other mods to use.Also, you're greatly overengineering things. Condition returns and line break avoidance don't improve readability. They might simplify the code from your standpoint, but I highly doubt any new developer would have a good time looking at it. You decided to limit yourself to just the singular sit/lay animations through
handle_action. That's fine with the mod being as it is (taking 2 commands as input), but anything more complex wouldn't do (say, a complex dance sequence of sneak+stand+sneak+mine).You could've just done
s/mcl/vlfon the original mod and it would've been much better.First of all. Thank you for taking the time to review this.
I update things as they are requested, hence the reason that It's not exactly an api anymore. My target audience isn't really developers. But more regular players.
As far as I'm aware the api has not really been used by any mods (except one. And that was yours),so if noone is going to use the api it is just a waste of resources. There's no point in adding something that people won't make use of. If someone wants to make use of an api for this. I'd gladly re-add the api. I try to make things as resource friendly as possible. I just can't see any use of wasting more resources on an api that probably won't be used. (no matter how few resources it uses)
I feel like your response comes down to this:
And I totally get it. That's normal. My target audience isn't developers either. But it doesn't change things.
The power of open-source is in collaboration. By making the code accessible only to you, you prevent people from contributing to it. A plumber won't be able to fix piping that they can't understand. (bad analogy but whatever)
BTW, what significance does "a greatly simplified and rewritten version" carry to regular players? That's clearly an attempt at selling this to developers, not players.
Offtopic: the screenshot you put in the long description doesn't render. You should link it to the ContentDB media file as everything else (e.g. imgur) seems to be broken by it.
I partly agree, but there's no point of adding something no one will use.
I'm not sure I understand this.
I accidently used the old readme (As In. I forgot to push the new one to git.)
If I was able to use it, anybody can. The question of will is not something I can control, and neither can any developer. Just because I'm not sure that there will be 9999 mods using my API doesn't mean I shouldn't expose it if I think it's useful.
You essentially decided to ignore the code style that Minetest (Game+mods) and MineClone family had adopted over the years and write whatever. I'm not arguing your code style is "wrong" or "bad", but instead that it's non-standard. This is better than if you ran your code through an obfuscator every time before releasing it to the public, yet it's worse than if you went on the comply route.
Again. Adopting an (at least somewhat) unified code style and guidelines helps everybody. Developer can get useful patches from Contributors; Contributors can have an understanding of the code they're given and learn from it too; Player can enjoy the results of that Developer-Contributor interaction (e.g. new features and whatnot). If I, as a Contributor, have to learn your specific code style just to understand your code and try and contribute to it, I might just not.
And don't forget most contributors are players too. People play mods and games, look inside to see how they work, and then try and change things.