an option to only dig upward, leaving the bottom of the trunk (before | after).
an option to stop before the tool breaks
an option to even more restrict horizontal digging for some specific types of dense trees. This can prevents clear-cutting entire jungle portions, at the cost of maybe leaving some wood behind (before | after)
Hopefully it keeps the simple spirit of the mod, while adding these few features.
At least the code is way shorter than this comment :)
Each change is optional and come as a new setting disabled by default, so that the default behavior stays the same
Each is in a separate commit, and the last one adds gif screeshots
I don't have a github account to send PR but I thought you might want
to use it anyway.
I completely agree with your suggestions, especially the first one. Currently, the mod does not affect the foliage because all the jungles share the same foliage. However, if we dig strictly from bottom to top and set some additional limits, it would be possible to remove the foliage as well.
Unfortunately, I currently don't have time for Minetest, but thank you very much for your suggestions. I will try to implement them in the future. If you had a GitHub account, I would accept your PR. Alternatively, you can fork the project and upload it under your name, or provide me with a link to your repository on another site. In that case, I could simply copy your code, make any necessary adjustments, and publish it.
May I ask, I see that you are familiar with Git and Lua, so you are likely a programmer. But why don't you have a GitHub account? Is it because you don't trust Microsoft?
I apologize for my inattentiveness. I watched the GIFs, but somehow I didn't notice the link to your repo. As soon as I have some free time, I will check out your fork. Thank you very much!
Of course, the leaves fall on their own, but for large trees, this process takes about a minute and it looks unnatural. Actually, it's not a problem and I wouldn't complicate the code for this purpose, but if possible, I would like to capture leaves along with adding other improvements.
I have added 2 out of 3 of your improvements and enabled them by default. I decided not to add the 'restrict horizontal digging' feature. I agree that it's needed, and I like the idea itself, but I'm not satisfied with the implementation. I would like the mod to work well with all types of trees without requiring any special configurations. Creating a list of special blocks is not very user-friendly. In the future, I'll try to come up with an alternative. Thanks again!
Thank you for looking into it, and i'm glad if this was useful
I agree that having to declare the list of nodes to apply restriction to, is very far from ideal...
As it is, it doesn't actually require any special configuration : if the server admin don't change the default config, it will dig uppward or on the same level for any kind of trees, but strictly uppward for jungle trees. But as said, I see your point and I understand why it doesn't fit.
I will keep thinking about how to do this in a better way, ... maybe by setting a radius for the orginal digged node or a limit to the number of node digged on the same level, this would probably work for any tree ...but this seems heavy too because that would mean keeping data on the first node pos accross all recusions.
Until then, I'm keeping a fork because I like being able to limit the "greediness" on my server but I've rebased it on your latest update
I like the simplicity of this mod ! ... but it works a bit too well for me, in the jungle I felt more like a buldozer than a lumberjack.
Also I use tool ranks mod and was very sad to see my level 8 axe break without warning
So I made a fork (here) that adds 3 things :
Hopefully it keeps the simple spirit of the mod, while adding these few features. At least the code is way shorter than this comment :)
Each change is optional and come as a new setting disabled by default, so that the default behavior stays the same
Each is in a separate commit, and the last one adds gif screeshots
I don't have a github account to send PR but I thought you might want to use it anyway.
I completely agree with your suggestions, especially the first one. Currently, the mod does not affect the foliage because all the jungles share the same foliage. However, if we dig strictly from bottom to top and set some additional limits, it would be possible to remove the foliage as well.
Unfortunately, I currently don't have time for Minetest, but thank you very much for your suggestions. I will try to implement them in the future. If you had a GitHub account, I would accept your PR. Alternatively, you can fork the project and upload it under your name, or provide me with a link to your repository on another site. In that case, I could simply copy your code, make any necessary adjustments, and publish it.
May I ask, I see that you are familiar with Git and Lua, so you are likely a programmer. But why don't you have a GitHub account? Is it because you don't trust Microsoft?
Thanks for the reply
The fork link was already in the initial comment :
About github, yes, as many, I left github when it was bought by microsoft :)
I didn't think about foliage, but once the tree has been cut, foliage disapear by itself
Having to dig manually to get the leaves seems fair to me
I apologize for my inattentiveness. I watched the GIFs, but somehow I didn't notice the link to your repo. As soon as I have some free time, I will check out your fork. Thank you very much!
Of course, the leaves fall on their own, but for large trees, this process takes about a minute and it looks unnatural. Actually, it's not a problem and I wouldn't complicate the code for this purpose, but if possible, I would like to capture leaves along with adding other improvements.
I have added 2 out of 3 of your improvements and enabled them by default. I decided not to add the 'restrict horizontal digging' feature. I agree that it's needed, and I like the idea itself, but I'm not satisfied with the implementation. I would like the mod to work well with all types of trees without requiring any special configurations. Creating a list of special blocks is not very user-friendly. In the future, I'll try to come up with an alternative. Thanks again!
Sorry I'm just seeing this now
Thank you for looking into it, and i'm glad if this was useful
I agree that having to declare the list of nodes to apply restriction to, is very far from ideal...
As it is, it doesn't actually require any special configuration : if the server admin don't change the default config, it will dig uppward or on the same level for any kind of trees, but strictly uppward for jungle trees. But as said, I see your point and I understand why it doesn't fit.
I will keep thinking about how to do this in a better way, ... maybe by setting a radius for the orginal digged node or a limit to the number of node digged on the same level, this would probably work for any tree ...but this seems heavy too because that would mean keeping data on the first node pos accross all recusions. Until then, I'm keeping a fork because I like being able to limit the "greediness" on my server but I've rebased it on your latest update