Your leads mod is a great addition to Minetest! Thank you! 😀 Unfortunately I have a problem which seems to be associated with your mod. Mintest 5.8.1 in a Mineclonia game (Windows 10 64bit) frequently crashes with:
AsyncErr: Lua: Runtime error from mod 'mcl_core' in callback luaentity_Step(): "Runtime error from mod 'mcl_core' in callback item_OnPlace(): ...oads\minetest-5.8.0-win64\bin\..\mods\leads/internal.lua:40: attempt to index local 'placer' (a nil value)
stack traceback:
...oads\minetest-5.8.0-win64\bin\..\mods\leads/internal.lua:40: in function <...oads\minetest-5.8.0-win64\bin\..\mods\leads/internal.lua:38>
[C]: in function 'place_node'
...n\..\games\mineclonia\mods\ENTITIES\mobs_mc/enderman.lua:537: in function 'do_custom'
...4\bin\..\games\mineclonia\mods\ENTITIES\mcl_mobs/api.lua:415: in function 'on_step_old'
...mes\mineclonia\mods\ENVIRONMENT\mcl_void_damage\init.lua:17: in function <...mes\mineclonia\mods\ENVIRONMENT\mcl_void_damage\init.lua:16>"
stack traceback:
[C]: in function 'place_node'
...n\..\games\mineclonia\mods\ENTITIES\mobs_mc/enderman.lua:537: in function 'do_custom'
...4\bin\..\games\mineclonia\mods\ENTITIES\mcl_mobs/api.lua:415: in function 'on_step_old'
...mes\mineclonia\mods\ENVIRONMENT\mcl_void_damage\init.lua:17: in function <...mes\mineclonia\mods\ENVIRONMENT\mcl_void_damage\init.lua:16>
Thank you very much, Silver Sandstone! :-) That was a very quick fix! I played Minetest/Mineclonia with your new mod version for some hours now and the error is gone! :-)
On another notice: I would like to translate any text there is in the mod, but I found no locale directory to do so. If there is only the mod title and item title it would be "Leinen" for "Leads" (plural) and "Leine" for "Lead". Otherwise I gladly translate any further text if necessary!
It would have been quicker if I hadn't spent half an hour trying to get an enderman to pick up a block to replicate the bug, only to find that I had mobs_griefing turned off.
Translations are always appreciated! I've added Leads to Codeberg Translate.
Thank you, I wasn't aware of this tool, looks quite handy! :-)
I wanted to add the German translations, but I get an error that the repository could not be pushed, so the translator is locked. I can add suggestions, but cannot do translations directly.
Someone else should double-check the translation as some translations would differ depending on context. I left "visuals" untranslated as this is often used as an anglicism in German language. And in one translation I left "mobs" untranslated for similar reasons (this time Minecraft/Minetest related). Furthermore I rephrased the translation for "Right-click on an animal or fence to attach a lead. Punch the lead to release it, or right-click on a fence to tether it." to make more clear what is ment by it.
The tooltip descriptions for the option diaglog are missing in the translations or I did not find it. If it's in the glossary section in Codeberg tranlations, this seems to be empty.
And a suggestion: Under "object types", if you write the "Allow leashing" once and then only list the object/mob names, this would be more clearly arranged imho. The German translation "Erlaube das Anbinden" is even longer. ;-)
Thanks! I'll include your translation in the next update.
Which strings need context? I can add notes for clarification.
Settings aren't translatable at the moment. I could add the tooltips anyway, but the strings will probably change before Minetest supports translating them.
I prefer to have a full description for each setting, so they make sense in search results. Thanks for the suggestion, though.
The first paragraph of my reply (not counting the thank you line at the beginning) was only a clarification, why I in those cases did not use the literal translation but something more understandable in German.
Regarding the missing text: In the Minetest main menu, if you go into the options and the options section of your Leads mod, if you hover with the mouse cursor on the circle with the "i", you get a tooltip with further text which was not included on translate.codeberg.org, or I did not find them. If you provide me with the text, I will gladly translate the rest of the text, too.
Regarding my suggestion: Ok, then I understand the repetition of the option text. :-)
I see you have other mods and I could help translate a few, maybe not all of them. Escpecially as I only use Leads yet and want to contribute what I can to MineClone2 and MineClonia.
But if you tell me two of your mods you would like me to provide German translations and (if not already done) upload to the translate page like you did with Leads, I will gladly work on them bit by bit whenever I have some time. :-)
Your leads mod is a great addition to Minetest! Thank you! 😀 Unfortunately I have a problem which seems to be associated with your mod. Mintest 5.8.1 in a Mineclonia game (Windows 10 64bit) frequently crashes with:
Thanks for the review.
This report is very helpful. I've released an update to fix the bug.
Thank you very much, Silver Sandstone! :-) That was a very quick fix! I played Minetest/Mineclonia with your new mod version for some hours now and the error is gone! :-)
On another notice: I would like to translate any text there is in the mod, but I found no locale directory to do so. If there is only the mod title and item title it would be "Leinen" for "Leads" (plural) and "Leine" for "Lead". Otherwise I gladly translate any further text if necessary!
It would have been quicker if I hadn't spent half an hour trying to get an enderman to pick up a block to replicate the bug, only to find that I had
mobs_griefingturned off.Translations are always appreciated! I've added Leads to Codeberg Translate.
Thank you, I wasn't aware of this tool, looks quite handy! :-)
I wanted to add the German translations, but I get an error that the repository could not be pushed, so the translator is locked. I can add suggestions, but cannot do translations directly.
I've addressed the push issue. You should be able to add translations now.
Thank you & done! :-)
Someone else should double-check the translation as some translations would differ depending on context. I left "visuals" untranslated as this is often used as an anglicism in German language. And in one translation I left "mobs" untranslated for similar reasons (this time Minecraft/Minetest related). Furthermore I rephrased the translation for "Right-click on an animal or fence to attach a lead. Punch the lead to release it, or right-click on a fence to tether it." to make more clear what is ment by it.
The tooltip descriptions for the option diaglog are missing in the translations or I did not find it. If it's in the glossary section in Codeberg tranlations, this seems to be empty.
And a suggestion: Under "object types", if you write the "Allow leashing" once and then only list the object/mob names, this would be more clearly arranged imho. The German translation "Erlaube das Anbinden" is even longer. ;-)
Thanks! I'll include your translation in the next update.
Which strings need context? I can add notes for clarification.
Settings aren't translatable at the moment. I could add the tooltips anyway, but the strings will probably change before Minetest supports translating them.
I prefer to have a full description for each setting, so they make sense in search results. Thanks for the suggestion, though.
The first paragraph of my reply (not counting the thank you line at the beginning) was only a clarification, why I in those cases did not use the literal translation but something more understandable in German.
Regarding the missing text: In the Minetest main menu, if you go into the options and the options section of your Leads mod, if you hover with the mouse cursor on the circle with the "i", you get a tooltip with further text which was not included on translate.codeberg.org, or I did not find them. If you provide me with the text, I will gladly translate the rest of the text, too.
Regarding my suggestion: Ok, then I understand the repetition of the option text. :-)
I can add setting tooltips to the template if you want to translate them, but they won't show up in Minetest because translating settings is currently not supported.
Other than that, there's nothing left to translate, unless you want to do another mod.
I see you have other mods and I could help translate a few, maybe not all of them. Escpecially as I only use Leads yet and want to contribute what I can to MineClone2 and MineClonia.
But if you tell me two of your mods you would like me to provide German translations and (if not already done) upload to the translate page like you did with Leads, I will gladly work on them bit by bit whenever I have some time. :-)